[OSM-dev] Feedback for Vespucci-dev

[Jan Schejbal]

Hi,
I have now made and committed the following changes.

- Add "Advanced Preferences" (and move some stuff there)

- Add pref to disable context menu in unnecessary cases
(default: enabled = show always)

- Add heuristics for context menu (to always show it when really
necessary). If the above-mentioned pref is unset, it basically works
like this: Get the list of touched objects. If there are OSMBugs, always
show. If there are no nodes but multiple ways, always show. If there is
at least one node, then the nearest node is considered to be clicked,
UNLESS this node has another node *really* close to it (not to the click
area). This ensures that exactly overlapping nodes and ways always bring
up the context menu, while other cases can be handled quickly. (Way
tolerance is low enough so it doesn't cause false hits.)

- Sort context menu entries by distance to click (nodes by distance
first, then ways by distance)

- Undo menu: Add background colors (black/white) and icons properly

I now always set background and foreground color. The problem before was
that I only set one of them and/or only in one case, I think. I also
added custom-made greyscale icons. Feel free to remove the icons if they
suck/eat too much space or remove the coloring if it causes problems (I
think it shouldn't this time). Color has the big plus over icons that it
a) doesn't need space and b) is easier to notice than small icons.

- Tag editor: Changed "X" icon size to match editor rows, force minimum
text field size

The text fields were REALLY small on my device, and the X was too large.
Indeed, the spacing between the fields was the "X" being larger than the
text fields. I gave the text fields a minimum height and a bottom border
to fix this, and shrunk the "X" so it is now aligned.

- Tag editor: Set autosuggest dropdown spacing to minimum text field
size - I chose to use 36dp as the height of one dropdown item (not
counting the spacers). This is already more than the text field size on
my device, which is 36dp *including* the spacers (and was even smaller
before I introduced the minHeight). If the fields and X are big enough
to hit, the autocomplete is too. If the autocomplete is too small, we
need to also enlarge the fields (in my tests, I didn't have trouble
hitting them correctly, though).

I suspect the field height could be device/style specific. I will test
the entire application on a Galaxy Ace (small low-res screen with
Samsung UI) as soon as I can. If it looks and works OK there and on the
Galaxy Nexus, it will probably be good for everything. We need to check
the ActionBar in the action modes and the tag editor on such a device.
Forcing menu items to appear using showAsAction="always" might cause
trouble if they don't fit, and if menu items with icons overflow, it
could be possible that it will be white icon on white background again.
(I "fixed" this for the main action bar by replacing the transparent
white with a non-transparent gray that will look the same on the
actionbar, but will be at least a bit visible on white backgrounds as
offered by overflow menu of the Samsung UI).


I did NOT make any changes to the content of the autosuggest (i.e.
re-add the duplicates or move the corresponding entries to top), so we
currently have a plain alphabetic list. I would like to hear some more
opinions on this if possible. Should we maybe remove the distinction
between recommended and "mandatory" tags and add them all when applying
a preset? Currently, recommended tags are more or less invisible to the
user, so we should do *something*.

Oh, and I just noticed that I forgot to update the appname.xml, but I am
not the first one. Should we maybe put a $Rev: $ SVN tag in there for
now? The dollar signs look nasty but it makes sure it's always up to date.


Kind regards,
Jan