[GraphHopper] What are pillar and tower Nodes? Rename to geometry and junction nodes?

[D KING]

I'd say that junction and geometry is more immediately descriptive and intuitive, though the meaning of tower/pillar isn't really obscure. It would seem a small but worthwhile improvement in comprehension/usability.





>________________________________
> From: Peter <graphhopper at gmx.de>
>To: graphhopper at openstreetmap.org 
>Sent: Monday, 1 December 2014, 16:01
>Subject: [GraphHopper] What are pillar and tower Nodes? Rename to geometry and junction nodes?
> 
>
>Hi all,
>
>as the naming is from 2 years ago I think it could be time to rename
>'tower' nodes into 'junction' nodes and 'pillar' nodes into 'geometry'
>nodes. What do you think, would this be (more) intuitive?
>
>Below a quick documentation which I would add otherwise to the docs.
>
>Kind Regards,
>Peter
>
>**
>From OpenStreetMap we fetch all nodes and create the routing graph but
>only a minority of them are actual junctions, which are the ones we are
>interested while routing. Those junction nodes I call tower nodes which
>also have a graphhopper node ID associated, going from 0 to
>graph.getNodes(). The helper nodes between the junctions I call 'pillar
>nodes' which can be fetched via edgeIteratorState.fetchWayGeometry
>
>_______________________________________________
>GraphHopper mailing list
>GraphHopper at openstreetmap.org
>https://lists.openstreetmap.org/listinfo/graphhopper
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/graphhopper/attachments/20141201/cae2caf1/attachment.html>