[GraphHopper] There must be bug on the subnetwork removal

[John Zhao]

I know...

The first subnetwork removal consider the oneway as bi-directional way.
(But isFoward==false and isBackward==false, will be considered block.)
Map<Integer, Integer> map = findSubnetworks();

like  37.78373608999855,-122.25065187925067 size: 34
It has a oneway connection to the main network. (The other connection has a
barrier=gate.)
So, they are not treated as the subnetwork at first.

Then when try to find the oneway, the directional is considered. So this
subnetwork are recognized.

unvisitedDeadEnds = removeDeadEndUnvisitedNetworks(singleEncoder);


*Best Regards,*
*ZhiQiang ZHAO*

On Thu, Jul 23, 2015 at 2:03 PM, John Zhao <johnthu at gmail.com> wrote:

> Interesting,
> when I increase minOnewayNetworkSize from 20 to 50, the following two
> disappeared.
> subnetwork start from: 37.32611992939085,-121.9961998312816 size: 24
> subnetwork start from: 37.78373608999855,-122.25065187925067 size: 34
>
> *Best Regards,*
> *ZhiQiang ZHAO*
>
> On Thu, Jul 23, 2015 at 1:55 PM, John Zhao <johnthu at gmail.com> wrote:
>
>> Hi,
>>
>> I tried car flag encoder with following parameter on San Francisco bay
>> area data from mapzen.
>>
>> https://s3.amazonaws.com/metro-extracts.mapzen.com/san-francisco-bay_california.osm.pbf
>>
>> minNetworkSize=200
>> minOnewayNetworkSize=20
>>
>> I printed all the remaining subnetworks.
>> edges: 591932, nodes 437420, there were 3496 subnetworks. removed them =>
>> 13121 less nodes. Remaining subnetworks:5
>> The remaining subnetworks are:
>> subnetwork start from: 37.32611992939085,-121.9961998312816 size: 24
>> subnetwork start from: 37.56018439442332,-122.30257814308803 size: 436637
>> subnetwork start from: 37.78373608999855,-122.25065187925067 size: 34
>> subnetwork start from: 38.180185962770565,-121.70631393878864 size: 301
>> subnetwork start from: 37.85717050411933,-122.07633641532816 size: 424
>>
>> I don't understand why there is still subnetwork less than 200 nodes.
>>
>> I have a look at 37.32611992939085,-121.9961998312816.
>> It seesm related with barrier=gate at intersection.
>> http://www.openstreetmap.org/node/1126492194
>>
>> *Best Regards,*
>> *ZhiQiang ZHAO*
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/graphhopper/attachments/20150723/92408a0f/attachment.html>