[josm-dev] Jumbo Patch

[Frederik Ramm]

Hi,

> OK, this is in the open source spirit of "release early release often".
> I've been hacking on JOSM for the purpose of making the TIGER merging
> easier.  Frederik, this implements some of the "reverse lookup" stuff
> that we were talking about a few weeks ago. 

You mean the stuff where I said I had once implemented something and
then Imi said he didn't like it ;-)

Just looked at the patch quickly -

1. That one method whose name begins with a double underscore... you
don't really mean it do you ;-)

2. I have never fully understood the "Merge" code in JOSM, i.e. what
happens when you load stuff from the server, of which some objects
were present already, others not, and some were present and now come
in a more recent version, while others were present and have been
changed *and* come in a new version (i.e. conflict detection). We have
to be reasonably sure that your code doesn't break these. Have you
done any tests in that direction? Someone else recently spoke of
improving the merge code, maybe he can help making sure this works.

3. I don't like the privatisation because it bloats the code: You have
to implement a ton of accessors and they all just "pass through"
stuff, only a tiny percentage actually does something different. But
that's the Java spirit probably... 

4. We have to test-compile the existing plugins against the core
changes and see if they still work.

But that's just a first impression, I haven't actually *used* it yet.
Maybe you can make a josm.jar available for those who want to
test-drive your changes?

Bye
Frederik

-- 
Frederik Ramm  ##  eMail frederik at remote.org  ##  N49°00.09' E008°23.33'