[josm-dev] PATCH: in "Draw" mode, extend current way

[matthew-osm at newtoncomputing.co.uk]

Hi,

Sorry - responding before I test the actual code...

On Sun, Oct 21, 2007 at 09:19:27PM +0200, Frederik Ramm wrote:
> 1. after extending any way, the way will always be selected (not the
>    newly added node as it was before).
> 
> 2. when clicking somewhere with a way selected,
> 
>    2a) if a node is also selected and that node is at the end of the
>        selected way, extend the selected way from the selected node;

Sounds good so far.

>    2b) if no node is selected but the last used node was at the end
>        of the selected way, extend the selected way from the last used
>        node

How do you determine "last used node"? You mean the last one
to be added / moved / ?


> 3. when clicking somewhere with only a node selected, act as before;
>    (ok this is not a change but good to mention it anyway)

...and select the new way? (I wondered about doing this in
my patch - maybe (1) above means this is now the case, in
which case good ;) ).

> 4. when clicking on a node with nothing selected, select that node;

Ooh, nice idea.

> 5. the "U" key clears the existing selection.
> 
> These changes aim to squeeze the last bit of productivity out of our
> poor mappers ;-) by further reducing mode switches (immediately tag
> the new way after you're finished, no need to go to "select" mode
> first), and they should give better control about which way is
> extended, if any.
> 
> Matthew, if this fails to cover anything that you wanted to achieve
> with your patch, do say!

That sounds great - I'll give it a go now and see how it
works.

On Sun, Oct 21, 2007 at 05:02:33PM -0400, Matthias Julius wrote:
> Frederik Ramm <frederik at remote.org> writes:
> 
> > 2. when clicking somewhere with a way selected,
> >
> >    2a) if a node is also selected and that node is at the end of the
> >        selected way, extend the selected way from the selected node;
> >    2b) if no node is selected but the last used node was at the end
> >        of the selected way, extend the selected way from the last used
> >        node
> 
> How about this?
> 
>    2c) if no node is selected and the last used node is not at an end
>        of the selected way, extend the selected way from the nearest
>        end

I also wondered about this for my patch - I think it would
probably be a good idea, and work most of the time. It
_could_ be extended thus:

  2c) if no node selected, and a way is selected, and last
  used node not at end of way:
    i) if there is a direct "segment" from one end to the
    new position, extend the selected way from that end
    ii) if there is a direct "segment" from both ends to the
    new position, extend the selected way from the closer
    end
    iii) otherwise (no direct "segments" from either end),
    extend way from the closer end.

  a "segment" is part of an existing way, i.e. you would be
  following an existing road or somesuch.

However, I think this may be a bit too complicated and
unnecessary.

> This would save another shift+click in most cases where more than one
> way ends at the desired node.

Yes - I like the idea.

Thanks,

-- 
Matthew