[josm-dev] Some bugfixes

Dirk Stöcker openstreetmap at dstoecker.de
Fri Jun 27 07:43:53 BST 2008


On Thu, 26 Jun 2008, Frederik Ramm wrote:

>> as I start to JOSM more and more, I made some patches for bugs which
>> disturb me.
>
> This is commendable and I'm sorry that I don't currently get to look
> through trac very often. I have committed your patches apart from 960
> which I think requires a bit of discussion; I don't think that the
> simple gettext method is quite ideal for i18n of presets - but I might
> be wrong.

I started to use the context based trc() first (implemented it :-), but 
switched to normal tr() again, as there are no real conflicts and the 
texts are translatable as they are.


P.S. For the MOTD fix, you removed an essential part.

Index: src/org/openstreetmap/josm/gui/GettingStarted.java
===================================================================
--- src/org/openstreetmap/josm/gui/GettingStarted.java  (Revision 662)
+++ src/org/openstreetmap/josm/gui/GettingStarted.java  (Arbeitskopie)
@@ -52,9 +52,10 @@
              try {
                  motdcontent = wr.read(baseurl + "/wiki/MessageOfTheDay");
              } catch (IOException ioe) {
-                motdcontent = "<html><body>\n<h1>" +
+                motdcontent = "<!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.0 Strict//EN\" \"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd\">\n" 
+
+                    "<html><body>\n<h1>" +
                      tr("JOSM, the Java OpenStreetMap editor") +
-                    "</h1>\n<h2>(" +
+                    "</h1>\n<h2 align=\"center\">(" +
                      tr ("Message of the day not available") +
                      ")</h2>";
              }

The align=\"center\" makes the display of the h2 text much nicer and the 
DOCUMENT type is required or the text in <style> tag is displayed directly 
instead of beeing interpreted.

The i18n fixes where only the additional parts of the fix I made after the 
offline fixes :-)

Ciao
-- 
http://www.dstoecker.eu/ (PGP key available)




More information about the josm-dev mailing list