[josm-dev] Some bugfixes

[Frederik Ramm]

Hi,

>> This is commendable and I'm sorry that I don't currently get to look
>> through trac very often. I have committed your patches apart from 960
>> which I think requires a bit of discussion; I don't think that the
>> simple gettext method is quite ideal for i18n of presets - but I  
>> might
>> be wrong.
>
> I started to use the context based trc() first (implemented it :-),  
> but
> switched to normal tr() again, as there are no real conflicts and the
> texts are translatable as they are.

I don't think *this* is the problem. The problem, in my view, is that  
if you use tr() to translate the presets, then every preset - and  
there are possibly many, presets are not a built-in thing, a  
preset .xml is more like a config file! - would have to be mirrored  
in the lang-xx plugins. I would rather have the preset translations  
inside the preset files.

> P.S. For the MOTD fix, you removed an essential part.
>
> The align=\"center\" makes the display of the h2 text much nicer  
> and the
> DOCUMENT type is required or the text in <style> tag is displayed  
> directly
> instead of beeing interpreted.

But the DOCUMENT was never there in the past, while <style> has  
always been there - and I never saw the text inside <style> displayed  
literally. I'll investigate.

Bye
Frederik

-- 
Frederik Ramm  ##  eMail frederik at remote.org  ##  N49°00'09" E008°23'33"