[josm-dev] 2 more bug fixes in relation handling

Jo ml at winfix.it
Sat Jun 28 07:12:00 BST 2008


Frederik Ramm schreef:
> Hi.
>
>   
>>> two more fixes:
>>> 701	[PATCH] Bug in relation handling splitting up ways
>>> 637	[PATCH] JOSM allows duplicate members in relations
>>>
>>> These two are very annoying :-)
>>>       
>   
>   
>> I second that! 637 made me pull my hair out a few times before I 
>> understood what was going on and why I was getting that 500 error. 701 
>> is annoying if you don't realise that you're breaking other people's work.
>>     
>
> I will commit 701 because people are using a lot of route relations
> nowadays.
>
> BUT:
>
> The new behaviour is only valid for *some* kinds of relations. Imagine
> for example a turn restriction - here it is absolutely wrong to make 
> both parts of the split way part of the relation.
>
> What JOSM needs to do is detect the type of relation, look it up in 
> some kind of list and determine what to do exactly.
>   
You are right. It's not as straightforward as it seems at first. It's 
probably true that more people are using route relations than any other 
type of relations. You'll get around to the more intelligent solution 
eventually, I'm sure of it.

Would it be very hard to check whether a way is already a member of a 
relation before adding it? Or is that also specific to route relations? 
i.e. are there other kinds of relations where the same member can appear 
multiple times?

Thanks,

Polyglot




More information about the josm-dev mailing list