[josm-dev] [patch] AlighInCircle action

[Frederik Ramm]

Hi Petr,

> how about my patch. Could it be commited, or is there something bad in it,  
> or I am silly and I can commit it myself?

You cannot commit it yourself but you can have an SVN commit account if 
you intend to continue contributing to JOSM.

Your patch was good except for some minor code style things which I 
modified slightly. Thank you for the patch, and I have applied it for 
tonight's build (r1090).

One issue that your patch has in common with the Orthogonalize function 
is that if you activate the "align in circle" function repeatedly, it 
creates a new change in the change history each time, whereas one would 
expect that something that is already a circle cannot be further aligned 
and thus would not trigger a change!

I am also a bit wary of all the magic "if you have this number of 
so-and-so objects selected then that will happen" behaviour but I think 
I might have started this vogue myself so I'll keep quiet for now.

Bye
Frederik

-- 
Frederik Ramm  ##  eMail frederik at remote.org  ##  N49°00'09" E008°23'33"