[josm-dev] [patch] AlighInCircle action

[Petr Dlouhý]

On Tue, 25 Nov 2008 00:14:58 +0100, Frederik Ramm <frederik at remote.org>  
wrote:

> Hi Petr,
>
>> how about my patch. Could it be commited, or is there something bad in  
>> it,  or I am silly and I can commit it myself?
>
> You cannot commit it yourself but you can have an SVN commit account if  
> you intend to continue contributing to JOSM.
>
> Your patch was good except for some minor code style things which I  
> modified slightly. Thank you for the patch, and I have applied it for  
> tonight's build (r1090).
>
> One issue that your patch has in common with the Orthogonalize function  
> is that if you activate the "align in circle" function repeatedly, it  
> creates a new change in the change history each time, whereas one would  
> expect that something that is already a circle cannot be further aligned  
> and thus would not trigger a change!

Yes, we need the threshold thing as for other similar functions, but it  
wasn't there before. I will try to look at it.
>
> I am also a bit wary of all the magic "if you have this number of  
> so-and-so objects selected then that will happen" behaviour but I think  
> I might have started this vogue myself so I'll keep quiet for now.

We probably need something for all actions - something like action context  
menu.
>
> Bye
> Frederik
>



-- 
Petr Dlouhý