[josm-dev] Commit access

[Dirk Stöcker]

On Mon, 6 Oct 2008, Henry Loenwind wrote:

>> I found no way to register a shortcut using a modifier. Did I overlook
>> anything. I wanted to removed the F1/F1 clash and make the About dialog
>> into Shift+F1.
>
> There is no way to register a modifier. That would defeat the whole
> point about being platform-independent. The code that registers a
> shortcut should not know about what modifiers the user's keyboard has at
> all.

Plattform dependency is fine, but we have to many shortcuts to live with 
the plain set of keys. So at least Shift, Ctrl and Alt must be accessible 
from the registration process.

> Also, there is no need to work around clashes other than change the
> ordering of the registerShortCut() calls so that they are in a logical
> order. So the Action for Help registers first, the one for About second.
> What modifiers they will get comes from the platform dependent setup and
> can be changed by the user (for 4 of the groups).

That wont work. Nobody will care for that implicit order later on. I agree 
that a conflict solver is a fine idea, but the standrad shortcut setup must be 
fixed or we will introduce a lot of shortcuts, which are different for 
each user depending on the fact in which order he used or installed JOSM 
and its plugins.

>> Then something does not work as expected. I should get the same silent
>> changes on each call. From call to call there are a lower number of these.
>
> No, you'll get each warning only once. A silent (==conole) one for
> shortcuts the user has not been exposed before (that's new shortcuts),
> or a popup window for shortcuts the user could have already used.

Well, as said -  That's bad. See above. The standard JOSM and all 
maintained plugins must have a conflict free set of internal shortcuts. As 
a result, I want to have a notice about conflicts all the time or newly 
introduced conflicts will go unnoticed during development.

> Also, please remember that you cannot "fix" clashes unless you know the
> keyboard setups of all systems JOSM could run. And that's impossible
> because we support plugins for new systems.

Is there really a Java-supporting system, which has no Shift, Alt and Ctrl 
keys?

> BTW: If you force About to Ctrl-F1 to avoid the conflict with Help on
> F1, you'll re-introduce a nice platform-dependency. For OSX-Users About
> will then also be on Ctrl-F1, where it would have been on F1 by default.
> (And Cmd-F1 as first fallback and Shift-Cmd-F1 as second fallback). ---
> "system:help" is Cmd-? on OSX (once I find out how to bind "?" from Java)...

At the moment I get <F1> for about and <Shift>+<F1> for Help which is in 
no way a sensible setting on Linux or Windows.

Ciao
-- 
http://www.dstoecker.eu/ (PGP key available)