[josm-dev] Cleaning up i18n/build.xml

Marko Mäkelä marko.makela at iki.fi
Tue Mar 3 19:59:34 GMT 2009


On Wed, Jan 28, 2009 at 11:55:49AM +0200, Marko Mäkelä wrote:
> > >>>I would have committed it already, but I think
> > >>>that the best place for the added .jar file is in core/lib, and I
> > >>>don't have commit access to that repository.  Could someone
> > >>>add gettext-ant-tasks-0.9.3.jar to
> > >>
> > >>No. It is only used in i18n, so it should be there.
> > >
> > >OK, I will create i18n/lib for it then.  Any objections against
> > >committing the patch?
> > 
> > No. Looked fine to me, if it works :-)
> 
> It works, but I just noticed that it will write absolute paths to the
> *.po files instead of relative ones, like the current build system does.
> I'll try to see how I can fix that.  This is my first encounter with Ant.

Finally, http://code.google.com/p/gettext-commons/issues/detail?id=9
was fixed in gettext-ant-tasks-0.9.6.jar.  I committed the patch to
josm/i18n but did not commit the rebuilt po directory or generated files,
because I didn't want to step on anyone's toes with that.

Because the file names should be sorted by gettext-ant-tasks, this patch
should make conflicts in *.po files less common.  The old exec rule did
not attempt to sort the output of the "find" command, and thus the order
of the files listed in the *.po files may have changed between invocations.

Could someone who knows the copyright licenses and the practices in Java
projects please advise if the file gettext-ant-tasks-0.9.6.jar should be
listed in some README file or something?  The josm-core already incorporates
gettext-commons-0.9.2.jar.  Both files seem to be covered by the GNU LGPL.

Best regards,

	Marko




More information about the josm-dev mailing list