[josm-dev] Handling of "invisible" objects and conflict system simplification

[Upliner]

Hello all.

Can anybody tell something about handling of "invisible"(deleted on the
server) objects in JOSM? Specifically, why it was needed to write so
overcomplicated visibility conflict resolution system with
PurgePrimitivesCommand and UndeletePrimitivesCommand? There is much more
simple solution: just not to send delete command to the server for
"invisible" objects and to send mere undelete command for undeleted objects.
The OSM API supports object undeletion without changing primitive ID.

I've created the branch on the GitHub with this simplifications:
http://github.com/Upliner/josm/commits/newconflicts
compiled jar can be downloaded here:
http://upliner.openstreetmap.ru/josm/patches/josm-newconflicts.jar
Comments to some of changes can be found in the gist:
http://gist.github.com/440399

Can anybody review or test it? I know, it has some irregulatities like
visiblity conflict resolution in VersionConflictResolveCommand, but it can
be easily fixed if I find out more about the conflict system.
Thanks in advance.
-- 
Best regards,
Upliner