[josm-dev] Process to commit a patch ?

Axel Kollmorgen akollmorgen at gmail.com
Sat Nov 13 14:37:30 GMT 2010


On 2010-11-13 20:50, Dirk Stöcker wrote:
> On Sat, 13 Nov 2010, Olivier Croquette wrote:
>>> Olivier Croquette wrote:
>>>> I would like to commit the patch below [...]
>>>
>>> Just do it. :)
>>
>> Looks quite different than the process by Axel :-)

i was just summarizing my experience from trying to get a patch [1][2] in :)

>> What I don't like in Axel's process is "note that it might take a
>> while to get some feedback"...
>>
>> According to :
>> http://josm.openstreetmap.de/wiki/DevelopersGuide/SVN_Account
>> it's not mandatory to use Trac or review the changes.
>
> For everything else we are much happier when you just do it instead of
> bothering us with Trac tickets ;-)

hm - wasn't aware (or didn't think) of that. so if i had a svn account, 
could i just check in my gpx upload patch (which makes gpx upload work 
with oauth, among others)? this would indeed speed up things.

@ Sebastian / other committers: the refactoring of the core code for a 
cleaner patch for [2], as discussed here on the list, will take some 
time. would you mind looking at the patch that exists now and, if 
possible, commit it - so we have a working solution now? thanks!

ax

[1] 
http://lists.openstreetmap.org/pipermail/josm-dev/2010-November/004954.html
[2] http://josm.openstreetmap.de/ticket/4498#comment:3




More information about the josm-dev mailing list