[josm-dev] Expanded functionality of Join Areas action
Viesturs Zariņš
viesturz at gmail.com
Thu Oct 7 13:32:43 BST 2010
Hi,
On 2010.10.07. 14:29, Sebastian Klein wrote:
> Hi,
>
> I wonder if the user would expect all these features from a "Join
> Areas" command. How would you call it then, "Swiss Army Knife for Areas"?
>
> Why not have one tool for joining areas and another tool for creating
> them?
I see your point.
>
> (Just in case you don't know already: There are Multipolygon creation
> plugins (with very limited functionality) and a class
> data.osm.visitor.paint.relations.Multipolygon to detect inner and
> outer rings.)
I am aware of this plugin and it's limited functionality.
>
> The multipoly plugin will be included in JOSM core as soon as it has
> all features that you would expect from such a tool. (E.g. create
> multipolygon from "several unclosed ways that together form a closed
> way".) So you can either get svn access (if you don't have already)
> and hack on the multipoly plugin or simply post the patch for josm
> core at the bug tracker.
I will take a look at the multipoly plugin. I expect to reuse much of
code written for Join Areas and would not like to copy it around. That
was the technical reason behind making a Swiss army knife.
I don't have svn access, can you give me one to split the shared code
out into a separate tools class ( GeometryAlgorithms )?
>
>
> Sebastian
>
>
> Viesturs Zariņš wrote:
>> Hi,
>>
>> I am new to this list, but not new to JOSM.
>> I would like to propose expanded functionality of Join Areas command
>> and would like to hear your comments.
>> Let's make it into a multipolygon making tool.
>>
>> I propose two new use cases:
>> - select outer and inner way that have no intersections. Joining them
>> makes a multipolygon, transfers all relevant tags from outer way to
>> the multipolygon.
>> - select several unclosed ways that together form a closed way.
>> Joining them makes a new multipolygon.
>>
>> Ultimately I see the Join areas as a tool to "Make an area out of the
>> selected ways, no matter what it takes" and the tool will do all that
>> is necessary to do so.
>>
>> I am willing to implement the change, and have sufficient experience
>> on improving existing current implementation of Join Areas ( see bug
>> #5179).
>>
>> Cheers,
>> Viesturs
>
> _______________________________________________
> josm-dev mailing list
> josm-dev at openstreetmap.org
> http://lists.openstreetmap.org/listinfo/josm-dev
Viesturs
More information about the josm-dev
mailing list