[josm-dev] Request for review of plugins

Marián Kyral mkyral at email.cz
Tue Feb 25 13:27:11 UTC 2014


Dne 25.2.2014 12:55, Dirk Stöcker napsal:
> On Tue, 25 Feb 2014, Marián Kyral wrote:
> 
>>>  https://josm.openstreetmap.de/wiki/DevelopersGuide/DevelopingPlugins
>> 
>> Yes, I read this page, several times ;-)
>> I think, it needs some improvements. E.g.: how to handle version in 
>> manifest
>> for new plugin without commit to svn (se below).
> 
> Feel free to improve it...

But I don't know how :-(

> 
>>>  a) You aren't required to have plugins in OSM-SVN. External plugins 
>>> are
>>>  also supported, see https://josm.openstreetmap.de/wiki/Plugins , but 
>>> SVN
>>>  has some advantages (like translations).
>> 
>> No I aren't, but in case of Tracer plugin it is much better to update 
>> the
>> source. It will avoid all possible future issues.
>> I would like to keep git and sync it with the JOSM svn (via git-svn or 
>> by
>> applying patches)
>> 
>> Teoretically, I could manage PoinInfo externally, but I have an issue 
>> with
>> versions in Manifest file. I tried git mirror - but I was not able to 
>> compile
>> plugins. Now I'm using svn tree, but ant requires at least one commit 
>> of the
>> new plugin, otherwise "ant dist" fails in target init-svn-revision-xml
>> I have no idea how to fix it without commit to JOSM svn. As an 
>> workaround,
>> I've changed <arg value="."/> to <arg value="../tracer"/>.
> 
> ... or fix the build-common.xml. When reading the text it tells me, 
> that
> svn should fail and git be used instead. Seems your svn does not fail
> enough? It probably delivers something. Maybe a check is needed to 
> detect
> that invalid output?

I have official svn copy and I've created a new plugin folder. Git is 
used only inside pointInfo folder.

What I get:

[pointInfo (master)]$ ant dist
Picked up _JAVA_OPTIONS: -Dawt.useSystemAAFontSettings=on
Buildfile: 
/home/marian/data/josm/josm_plugins/plugins/pointInfo/build.xml

init:

compile:
      [echo] compiling sources for ../../dist/pointInfo.jar ...

init-svn-revision-xml:
      [exec] Result: 1

init-git-revision-xml:

revision:
[xmlproperty] [Fatal Error] :-1:-1: Premature end of file.

BUILD FAILED
/home/marian/data/josm/josm_plugins/plugins/build-common.xml:193: Failed 
to load 
/home/marian/data/josm/josm_plugins/plugins/pointInfo/REVISION.XML

Total time: 1 second

When I rename .git to .git_ it changes a little:

[pointInfo]$ ant dist
Picked up _JAVA_OPTIONS: -Dawt.useSystemAAFontSettings=on
Buildfile: 
/home/marian/data/josm/josm_plugins/plugins/pointInfo/build.xml

init:

compile:
      [echo] compiling sources for ../../dist/pointInfo.jar ...

init-svn-revision-xml:
      [exec] Result: 1

init-git-revision-xml:
      [exec] Result: 128

revision:
[xmlproperty] [Fatal Error] REVISION.XML:1:1: Content is not allowed in 
prolog.

BUILD FAILED
/home/marian/data/josm/josm_plugins/plugins/build-common.xml:193: Failed 
to load 
/home/marian/data/josm/josm_plugins/plugins/pointInfo/REVISION.XML

Total time: 1 second

What I want - plugin compiles. Maybe use some default value in MANIFEST.

> 
> Still we encourage using the SVN for several reasons, I18n and
> installation history for old JOSM versions are the two most important
> ones.
> 

I18n - do you mean lauchpad integration? - I don't like launchpad. I 
want to download .po file without registration (but this is a different 
story)

Regards,
Marián





More information about the josm-dev mailing list