[osmosis-dev] TaskRegistrar.patch

[Brett Henderson]

Marcus Wolschon wrote:
> (shouldn't this have been a CC to the new osmosis-dev -list instead
> of osm-dev?)
>   
Um, yes :-)  I thought I had.
>> Do you have a sample plugin that could be used as an example?  Ideally 
>> the wiki should be updated to describe how plugins work.
>>     
>
> I can do some of that. No problem.
>
>   
>> I haven't merged your changes to entity classes yet.  They're one part 
>> of osmosis that I'm fairly particular about and I don't want to add 
>> methods without making them consistent across the board.  Part of this 
>> is deciding once and for all whether entity classes should be immutable 
>> or not.  Your changes are still available on the jpf-plugin branch 
>> though so aren't lost.
>>     
>
> Sure. It's your call.
I'd like you to be able to use osmosis without patching it so I'll 
definitely take another look at this.  I must make your life difficult 
every time I have a "great" idea and decide to change things again :-)
>> As for the code, I haven't made many functional changes, mainly 
>> formatting updates to match existing conventions.
>> * I've made the plugin manager non-static which seems to work (I hope I 
>> haven't broken anything).
>> * I've updated some argument names to match existing conventions 
>> (removal of 'a' prefixes on method arguments is one, I don't understand 
>> what the purpose of them is).
>> * Removed final keyword from method arguments.  Again, just a convention 
>> thing because I haven't done it elsewhere.
>>     
>
> These 2 are conventions from checkstyle I'm used to. They avoid errors
> where one assigns a value to a parameter instead of a field or
> instead of a local variable.
>   
I'm in the process of updating the build process now.  My first step is 
to incorporate ivy for dependency management which I hope doesn't cause 
too much pain.  In theory it should make things cleaner without needing 
to load up svn with all of the dependency jar files.

Next will be to incorporate checkstyle.  I want to do that so that I can 
enforce some basic coding conventions.  That and some standard eclipse 
formatting rules should make patches simpler.  From memory checkstyle 
can detect where a value is assigned to a parameter without requiring 
the 'a' prefix but I'll check it out.

I suspect checkstyle will have a field day with checks such as npath 
complexity ...

Brett