[osmosis-dev] Checkstyle

[Brett Henderson]

Hi All,

I've added checkstyle to the build.  It doesn't run by default, it can 
only be run via "ant checkstyle".  With ivy dependency management in the 
build it makes these tools easy to hook in ...

This is more of an FYI at the moment because if you run it you'll be 
overwhelmed with hundreds of errors.  I've used the standard "sun" rules 
as a starting point, commented out a bunch of the noisiest ones 
temporarily, started making a few code cleanups and decided the job is 
going to be a big one.  I don't want to turn coding into a nightmare 
trying to pass checkstyle, but it would be nice to enforce some basic 
good practices or at least find out where the problems are.

One slighly irritating thing is that standard "eclipse" formatting 
differs in many ways to standard "checkstyle" rules.  The old favourite 
of tabs versus spaces is one of them :-)  I might just comment all tests 
out then introduce them one by one to see what gives the most bang for 
buck.  I don't want to spend too much time on it this either so I'll see 
how I go.

Anyway, it's there if you want to have a play.

Brett

PS. You'll probably have to run "ant resolve" after your next "svn update".