[OSM-Photos] bug: Opera: no masking saved

[Matija Nalis]

On Sun, Sep 27, 2009 at 07:34:18AM +0200, malenki wrote:
> When I mask something using Opera, mark all pictures as safe and click
> "save", I get the message 
> 
> <openstreetview.org>
> 
> The following errors were found:
> 	There was an error saving your changes
> 	There was an error saving your changes
> 
> For every picture not saved one line 
> "There was an error saving your changes"
> is shown.

There is the same situation in Firefox3 (more exactly, Iceweasel 3.0.6 on
Debian Lenny AMD64). If pictures are not modified (or if they have been
modified by somebody else in some previous moderation round), I can approve
them OK. But if I have modified them, there comes "There was an error saving
your changes".

I've installed a local copy of OSV code, and I can reproduce same error
here, on server side it says things like:

  Photo Columns (1.0ms)   SHOW FIELDS FROM `photos`
  Photo Load (0.1ms)   SELECT * FROM `photos` WHERE (`photos`.`filename` = '12c682ac2c12ae5f574ed6142ce01cb900a4536d') LIMIT 1
Completed in 30ms (View: 1, DB: 3) | 200 OK [http://localhost/private/processed/12c682ac2c12ae5f574ed6142ce01cb900a4536d-large.jpg?0.27420096484478795]
setting moderator for user 2 and photo 1
checking m.user_id=2 against u.id=2
Streaming file private/processed/12c682ac2c12ae5f574ed6142ce01cb900a4536d-large.jpg
  SQL (4.6ms)   SET SQL_AUTO_IS_NULL=0


Processing Api::PhotoController#mask (for 127.0.0.1 at 2009-09-28 21:50:48) [POST]
  Parameters: {"authenticity_token"=>"aCoC1WW0QLbtzUD+4Chs6REjN4VTkkHch3ZR97W8F+I=", "id"=>"1", "{\"id\":undefined, \"key\":\"mask\", \"value\":\"face\", \"area\":\"497,358 31x31\", \"deleting_user_id\":undefined},{\"id\":undefined, \"key\":\"mask\", \"value\":\"faces\", \"area\":\"574,363 191x38\", \"deleting_user_id\":undefined}"=>nil}
  User Columns (0.7ms)   SHOW FIELDS FROM `users`
  User Load (0.1ms)   SELECT * FROM `users` WHERE (`users`.`id` = 2) LIMIT 1
  Photo Columns (0.8ms)   SHOW FIELDS FROM `photos`
  Photo Load (51.5ms)   SELECT * FROM `photos` WHERE (`photos`.`id` = 1) 
  Moderator Load (63.0ms)   SELECT * FROM `moderators` WHERE (`moderators`.photo_id = 1)
  Moderator Columns (0.5ms)   SHOW FIELDS FROM `moderators`
  Moderator Load (2.2ms)   SELECT * FROM `moderators` WHERE (`moderators`.`photo_id` = '1' AND `moderators`.`user_id` = 2) LIMIT 1

JSON::ParserError (349: unexpected token at '{"id":undefined, "key":"mask", "value":"face", "area":"497,358 31x31", "deleting_user_id":undefined},{"id":undefined, "key":"mask", "value":"faces", "area":"574,363 191x38", "deleting_user_id":undefined}]'):
  /usr/lib/ruby/1.8/json/common.rb:122:in `parse'
  /usr/lib/ruby/1.8/json/common.rb:122:in `parse'
  app/models/tag.rb:10:in `from_json'
  app/controllers/api/photo_controller.rb:34:in `mask'
  app/controllers/api/application_controller.rb:38:in `catch_errors'
  /usr/lib/ruby/1.8/mongrel.rb:159:in `process_client'
  /usr/lib/ruby/1.8/mongrel.rb:158:in `each'
  /usr/lib/ruby/1.8/mongrel.rb:158:in `process_client'
  /usr/lib/ruby/1.8/mongrel.rb:285:in `run'
  /usr/lib/ruby/1.8/mongrel.rb:285:in `initialize'
  /usr/lib/ruby/1.8/mongrel.rb:285:in `new'
  /usr/lib/ruby/1.8/mongrel.rb:285:in `run'
  /usr/lib/ruby/1.8/mongrel.rb:268:in `initialize'
  /usr/lib/ruby/1.8/mongrel.rb:268:in `new'
  /usr/lib/ruby/1.8/mongrel.rb:268:in `run'

Rendered rescues/_trace (51.7ms)
Rendered rescues/_request_and_response (0.5ms)
Rendering rescues/layout (internal_server_error)


-- 
Opinions above are GNU-copylefted.