[OSM-Photos] bug: Opera: no masking saved

[John McKerrell]

On 28 Sep 2009, at 22:58, Matija Nalis wrote:

> On Sun, Sep 27, 2009 at 07:34:18AM +0200, malenki wrote:
>> When I mask something using Opera, mark all pictures as safe and  
>> click
>> "save", I get the message
>>
>> <openstreetview.org>
>>
>> The following errors were found:
>> 	There was an error saving your changes
>> 	There was an error saving your changes
>>
>> For every picture not saved one line
>> "There was an error saving your changes"
>> is shown.
>
> There is the same situation in Firefox3 (more exactly, Iceweasel  
> 3.0.6 on
> Debian Lenny AMD64). If pictures are not modified (or if they have  
> been
> modified by somebody else in some previous moderation round), I can  
> approve
> them OK. But if I have modified them, there comes "There was an  
> error saving
> your changes".
>
> I've installed a local copy of OSV code, and I can reproduce same  
> error
> here, on server side it says things like:
>
> JSON::ParserError (349: unexpected token at '{"id":undefined,  
> "key":"mask", "value":"face", "area":"497,358 31x31",  
> "deleting_user_id":undefined},{"id":undefined, "key":"mask",  
> "value":"faces", "area":"574,363 191x38",  
> "deleting_user_id":undefined}]'):

The problem here is the "undefined" bits, though it's valid  
JavaScript, JSON is a subset and only allows "null" values. I'm using  
a plugin for jQuery that converts an object to JSON, in Firefox 3.5  
it's using a native serializer but in other browsers it's using its  
own code, which is buggy. I've fixed the bug and reported it to the  
project maintainers, Opera 10 appears to work and so should the other  
browsers.

John