[Potlatch-dev] Vector layers from config file

Richard Fairhurst richard at systemeD.net
Sun Nov 28 23:50:46 GMT 2010


Andy Allan wrote:
> Are there other modes? What about the Importers all working with
> arrays of files?
>
> Anyway, thoughts welcome, especially the "whoa there, you're missing
> the obvious" variety.

It all sounds good (and previous comments about Connection and 
VectorLayer one day both inheriting from a base class still apply :) ).

The reason the importers have arrays is basically an artefact of 
shapefiles being split into three (.shp, .shx, .dbf), no more.

On a related note:

I've moved the code to handle stylesheets.xml and imagery.xml out of 
potlatch2.mxml and EditController.as, where they were rather unhappily 
sitting before, and into net.systemeD.potlatch2.collections. It might be 
worth considering the same treatment for vectors.xml.

The idea is that the code that deals with managing/editing these 
collections will sit there; the actual "do stuff with the individual 
object" code hasn't moved (i.e. net.systemeD.halcyon.styleparser and 
TileSet.as respectively).

It's the first time I've written singleton-like stuff (three in one day 
- FunctionKeyManager.as is one too :) ) so if anyone fancies casting an 
eye over it and neatening it, that'd be cool. (I suspect more stuff 
should be declared as static.) Similarly, I have a suspicion the event 
bindings might be over-engineered... but who knows. Flex bindings make 
my head hurt.

cheers
Richard



More information about the Potlatch-dev mailing list