[Potlatch-dev] Outstanding pull requests (Attn Richard F)

Richard Fairhurst richard at systemeD.net
Tue Jul 17 12:52:21 BST 2012


On 17/07/2012 12:30, Steve Bennett wrote:
> Could we consider changing the process? Any of these things would help:
> 1) A dev build where almost all pull requests are accepted, and which
> is the accepted starting point for new features. (The production build
> is a subset of those branches)
> 2) More reviewers/people with permission to accept pull requests for
> the prod build
> 3) Lower standard required to accept pull requests.

Very happy with 1 if someone would like to set that up. Very happy with 
more people helping to review the code too.

Also very happy if anyone wants to make the pull requests easier to 
review. So, for example, https://github.com/systemed/potlatch2/pull/66 
completely reindents everything - I can't see what's changed and what 
hasn't. If someone were to resubmit this so that only the changed lines 
are shown, that would be great.

Also, given that you've preached at me several times on this list on the 
best and most friendly way to deal with people, I would perhaps say that 
a personal mail would have been nice before a public calling out. :(

Richard




More information about the Potlatch-dev mailing list