[Potlatch-dev] Outstanding pull requests (Attn Richard F)

[Steve Bennett]

On Tue, Jul 17, 2012 at 9:52 PM, Richard Fairhurst <richard at systemed.net> wrote:
> Very happy with 1 if someone would like to set that up. Very happy with more
> people helping to review the code too.

Could we start with a "dev" branch that all pull requests should be
made to (and are accepted by default)? Or perhaps a "reviewr"
repository to which push permission can be readily granted, for
features that need reviewing? I unfortunately don't have a perfect
solution - but perhaps someone else does.

>
> Also very happy if anyone wants to make the pull requests easier to review.
> So, for example, https://github.com/systemed/potlatch2/pull/66 completely
> reindents everything - I can't see what's changed and what hasn't. If
> someone were to resubmit this so that only the changed lines are shown, that
> would be great.

This is what I'm talking about. I spent several hours tracking down
that bug and finding a solution to it. If there was a dev branch that
this was accepted on, anyone could easily verify that the centroid
calculation is now fixed. Instead, it sits on a shelf for a month
because some reformatting made visual inspection difficult.

Before:
https://github.com/stevage/potlatch2/blob/74fc99c26e8362f8adda25958248f046a2ad20ff/net/systemeD/halcyon/WayUI.as

Note the broken formatting, lack of whitespace, and minimal comments.

After:
https://github.com/stevage/potlatch2/blob/9a8037a7ba692ddec4af5001eaadde62740ecefd/net/systemeD/halcyon/WayUI.as

> Also, given that you've preached at me several times on this list on the
> best and most friendly way to deal with people, I would perhaps say that a
> personal mail would have been nice before a public calling out. :(

Yeah, true - consider my karma reduced. I wanted to publicly vent my
frustration at the current process. I'd like to contribute more, but
not if this is the result: pull requests that get ignored for months
(or years!), or get fobbed off due to to some concern about formatting
or an imperfect UI.

If you're saying that the preferred mechanism is for contributors to
privately cajole the lead maintainer every time they want a pull
request looked at, then, no. All the pull requests are sitting right
there:

https://github.com/systemed/potlatch2/pulls

Speaking of which, here's another pull request I didn't mention earlier:
https://github.com/systemed/potlatch2/pull/67/commits

>From memory, that was something like 15+ hours work - completely
ignored. Meaning bad data continues to be created in the OSM database.
(https://trac.openstreetmap.org/ticket/4378 )

Is it unreasonable to expect quicker responses?

Steve