[openstreetmap-website] Changeset view (#20)

[Tom MacWright]

Okay, I'm a bit blocked from doing testing with large changesets that break
the map, since I have a limited extract of the database around.

I get that the other information is important, but it's important to
advanced users, and people who don't immediately grasp what a 'node' is are
blindsided by technical information - and presenting a map with the thing
highlighted makes it clearer. Hopefully we can please both camps.

I've experimented with more literate approaches to representing this
information, and have that implemented in the changeset view -
http://dl.dropbox.com/u/68059/Screenshots/k.png . Doing the same for node
views - which share code with node history views - is a bit more difficult,
and the whole endeavor is not easy to reconcile with translatable strings.
So I think this is an incremental improvement that can have further pushes.

That's also the main reason why the 'current version' text is how it is -
this page shares a partial with the history view. This might be resolvable
- I'll take a look and anyone else who wants to hack on this, you can grab
the changeset_view branch and jfdi.

Tom

On Mon, Feb 27, 2012 at 4:25 AM, Andy Allan <gravitystorm at gmail.com> wrote:

> On 27 February 2012 00:42, Tom Hughes <tom at compton.nu> wrote:
> > On 26/02/12 20:11, Tom MacWright wrote:
> >
> >> This refactors changeset views, node and way pages. It needs to be fully
> >> tested with ways - so far my database import isn't accepting them, so I
> >> don't have any test data. For these pages, it moves and enlarges the
> map,
> >> changes the styling of the menu, introduces some more clickable&
>  visible
> >> navigation.
> >>
> >>
> >> ![changeset](http://dl.dropbox.com/u/68059/Screenshots/g.png)
> >>
> >> You can merge this Pull Request by running:
> >>
> >>   git pull https://github.com/tmcw/openstreetmap-website changeset_view
> >
> >
> > I've added this to http://tomh.apis.dev.openstreetmap.org/ and I'd like
> to
> > know what people think.
>
> * The version number could do with alignment
> * Actually, I wonder if "Version 4 (current version) (view history)"
> or similar would be better as the subtitle - I'm not sure why the
> fixed text "Current version (view history)" would be the second-level
> title of the page
> * Edited at / edited by could easily be combined into "edited by tcmw
> at whenever (nicely formatted)"
> * If there's some way of making the coordinates available, but not as
> the (fairly prominent) final thing, that would be good. I know
> sometimes they are needed but the 6 decimal places make the page a
> little ugly.
>
> Basically, the list of attributes shown is so clearly just a
> one-by-one list of attributes on the model, and I think it can be
> improved!
>
> As for the bigger map, I can only echo Sarah's point. The
> mis-behaviour of the map when loading large relations (i.e. starting
> at the full world, and only zooming to the right place after the
> massive geometry has been loaded and parsed) might need to be fixed
> first before increasing the map prominence.
>
> Cheers,
> Andy
>
> _______________________________________________
> rails-dev mailing list
> rails-dev at openstreetmap.org
> http://lists.openstreetmap.org/listinfo/rails-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20120227/56a5cf4e/attachment.html>