[openstreetmap-website] Changeset view (#20)
Andy Allan
gravitystorm at gmail.com
Mon Feb 27 09:25:36 GMT 2012
On 27 February 2012 00:42, Tom Hughes <tom at compton.nu> wrote:
> On 26/02/12 20:11, Tom MacWright wrote:
>
>> This refactors changeset views, node and way pages. It needs to be fully
>> tested with ways - so far my database import isn't accepting them, so I
>> don't have any test data. For these pages, it moves and enlarges the map,
>> changes the styling of the menu, introduces some more clickable& visible
>> navigation.
>>
>>
>> 
>>
>> You can merge this Pull Request by running:
>>
>> git pull https://github.com/tmcw/openstreetmap-website changeset_view
>
>
> I've added this to http://tomh.apis.dev.openstreetmap.org/ and I'd like to
> know what people think.
* The version number could do with alignment
* Actually, I wonder if "Version 4 (current version) (view history)"
or similar would be better as the subtitle - I'm not sure why the
fixed text "Current version (view history)" would be the second-level
title of the page
* Edited at / edited by could easily be combined into "edited by tcmw
at whenever (nicely formatted)"
* If there's some way of making the coordinates available, but not as
the (fairly prominent) final thing, that would be good. I know
sometimes they are needed but the 6 decimal places make the page a
little ugly.
Basically, the list of attributes shown is so clearly just a
one-by-one list of attributes on the model, and I think it can be
improved!
As for the bigger map, I can only echo Sarah's point. The
mis-behaviour of the map when loading large relations (i.e. starting
at the full world, and only zooming to the right place after the
massive geometry has been loaded and parsed) might need to be fixed
first before increasing the map prominence.
Cheers,
Andy
More information about the rails-dev
mailing list