[openstreetmap-website] Add Wikidata-links to browse-helper (#786)
Florian Schäfer
notifications at github.com
Sun Jul 20 06:05:07 UTC 2014
This pull-request adds links to the corresponding item on [WikiData](www.wikidata.org) into the browse-helper similar to the wikipedia-tags. For now it's much simpler than with the wikipedia-tags, because it only takes the plain wikidata-tag into consideration (no namespaced tags like operator:wikidata) and also restricts the values to only `/[Qq][1-9][0-9]*/`.
I'll surely add the namespaced tags mentioned on the [WikiData-proposal-page](http://wiki.openstreetmap.org/wiki/Proposed_features/Wikidata) soon, because they are quite common (Streets/buildings named after or operated by a person/organization, …).
Another thing I'd find quite interesting would be, to show the wikidata-label additionally to the link. Either next to the link and somehow visually separated to show that this label is __not__ part of the tag-value, or in the text which appears when hovering the link.
This would make it much easier for a user to "encrypt" the wikidata-values.
Would this be a good idea?
Just wanted to ask before I put work into it.
You can merge this Pull Request by running:
git pull https://github.com/floscher/openstreetmap-website wikidata-links
Or you can view, comment on it, or merge it online at:
https://github.com/openstreetmap/openstreetmap-website/pull/786
-- Commit Summary --
* Added wikidata-links to the browse-helper (atm just the ones without namespaces).
* Added tests for wikidata-links in the browse-helper
-- File Changes --
M app/helpers/browse_helper.rb (12)
M config/locales/en.yml (1)
M test/helpers/browse_helper_test.rb (27)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/786.patch
https://github.com/openstreetmap/openstreetmap-website/pull/786.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/786
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20140719/3806a055/attachment.html>
More information about the rails-dev
mailing list