[openstreetmap-website] Turn wikimedia_commons values into links (#834)
Manfred Stock
notifications at github.com
Sat Nov 15 15:40:05 UTC 2014
This turns the value of the `wikimedia_commons` tag into a link to the respective page on `commons.wikimedia.org` (if it is a `File:` or `Category:` item) by enhancing the browse helper. See [1] for the tag description.
(Btw.: I have no hard feelings if this is rejected - I recently noticed this tag (which is not that popular yet, but the wiki page [1] is also fairly new), found it useful (since it seems to solve some of the issues of the `image` tag if images are available on Wikimedia Commons), and wanted to see how easy/hard it is to implement such a link.)
[1] http://wiki.openstreetmap.org/wiki/Key:wikimedia_commons
You can merge this Pull Request by running:
git pull https://github.com/mstock/openstreetmap-website feature/wikimedia-commons-link
Or you can view, comment on it, or merge it online at:
https://github.com/openstreetmap/openstreetmap-website/pull/834
-- Commit Summary --
* Turn wikimedia_commons values into links
-- File Changes --
M app/helpers/browse_helper.rb (12)
M config/locales/en.yml (1)
M test/helpers/browse_helper_test.rb (28)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/834.patch
https://github.com/openstreetmap/openstreetmap-website/pull/834.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/834
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20141115/e0c31976/attachment.html>
More information about the rails-dev
mailing list