[openstreetmap/openstreetmap-website] Tag factories (#1367)

[Andy Allan]

This PR replaces fixtures with factories for node/way/relation tags.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/1367

-- Commit Summary --

  * Replace fixtures with a factory for old_node_tags
  * Convert fixtures to factory for old_way_tags
  * Replace fixtures with a factory for old_relation_tags
  * Replace fixtures with factory for node_tags
  * Replace fixtures with factory for way_tags
  * Replace fixtures with factory for relation_tags

-- File Changes --

    M .rubocop_todo.yml (2)
    M test/controllers/amf_controller_test.rb (3)
    M test/controllers/api_controller_test.rb (6)
    M test/controllers/changeset_controller_test.rb (5)
    M test/controllers/node_controller_test.rb (7)
    M test/controllers/old_node_controller_test.rb (15)
    M test/controllers/old_way_controller_test.rb (10)
    M test/controllers/relation_controller_test.rb (2)
    M test/controllers/search_controller_test.rb (10)
    M test/controllers/way_controller_test.rb (12)
    A test/factories/node_tags.rb (9)
    A test/factories/old_node_tags.rb (10)
    A test/factories/old_relation_tags.rb (10)
    A test/factories/old_way_tags.rb (10)
    A test/factories/relation_tags.rb (9)
    A test/factories/way_tags.rb (9)
    D test/fixtures/current_node_tags.yml (64)
    D test/fixtures/current_relation_tags.yml (49)
    D test/fixtures/current_way_tags.yml (29)
    D test/fixtures/node_tags.yml (113)
    D test/fixtures/relation_tags.yml (77)
    D test/fixtures/way_tags.yml (77)
    M test/helpers/browse_helper_test.rb (41)
    M test/models/node_tag_test.rb (61)
    M test/models/node_test.rb (15)
    M test/models/old_node_tag_test.rb (57)
    M test/models/old_node_test.rb (35)
    M test/models/old_relation_tag_test.rb (57)
    M test/models/old_relation_test.rb (35)
    M test/models/old_way_tag_test.rb (57)
    M test/models/old_way_test.rb (46)
    M test/models/relation_tag_test.rb (51)
    M test/models/relation_test.rb (17)
    M test/models/way_tag_test.rb (51)
    M test/models/way_test.rb (15)
    M test/test_helper.rb (16)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/1367.patch
https://github.com/openstreetmap/openstreetmap-website/pull/1367.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1367
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20161109/06d02a69/attachment.html>