[openstreetmap/openstreetmap-website] Replace trace-related fixtures with factories. (#1347)

[Andy Allan]

The mocking and stubbing in the controller tests is
unfortunate, but the models interact directly with the filesystem
using the trace id so that's hard to control any other way.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/1347

-- Commit Summary --

  * Replace trace-related fixtures with factories.

-- File Changes --

    M test/controllers/amf_controller_test.rb (2)
    M test/controllers/api_controller_test.rb (13)
    M test/controllers/site_controller_test.rb (2)
    M test/controllers/swf_controller_test.rb (8)
    M test/controllers/trace_controller_test.rb (683)
    M test/controllers/user_controller_test.rb (10)
    A test/factories/tracepoints.rb (11)
    A test/factories/traces.rb (16)
    A test/factories/tracetags.rb (7)
    D test/fixtures/gps_points.yml (35)
    D test/fixtures/gpx_file_tags.yml (19)
    D test/fixtures/gpx_files.yml (129)
    M test/integration/oauth_test.rb (12)
    M test/models/trace_test.rb (178)
    M test/models/tracepoint_test.rb (9)
    M test/models/tracetag_test.rb (8)
    M test/test_helper.rb (5)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/1347.patch
https://github.com/openstreetmap/openstreetmap-website/pull/1347.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1347
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20161029/6e97a2c5/attachment.html>