[openstreetmap/openstreetmap-website] Add rubocop coverage to xml builders (#1277)

Andy Allan notifications at github.com
Wed Sep 7 10:21:45 UTC 2016

Rubocop doesn't cover the xml builder files (**/*.builder) automatically, so there were quite a few niggles with them.

Most were autofixes. The most important two to review are the consider_pd and terms_agreed changes, which have separate commits.
You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * User.consider_pd is boolean, so no need for double negation.
  * Use .present? instead of double negative to check if terms_agreed timestamp is set.
  * Add outer variable shadowing to rubocop_todo.yml
  * Rubocop autofixes.
  * Add xml builder files to rubocop.
  * Update offense counts in rubocop_todo.yml

-- File Changes --

    M .rubocop.yml (4)
    M .rubocop_todo.yml (23)
    M app/views/api/permissions.builder (4)
    M app/views/changeset/_comments.rss.builder (8)
    M app/views/changeset/comments_feed.rss.builder (7)
    M app/views/changeset/list.atom.builder (20)
    M app/views/changeset/timeout.atom.builder (8)
    M app/views/diary_entry/rss.rss.builder (12)
    M app/views/notes/_note.gpx.builder (6)
    M app/views/notes/_note.rss.builder (12)
    M app/views/notes/_note.xml.builder (4)
    M app/views/notes/feed.rss.builder (14)
    M app/views/notes/index.gpx.builder (2)
    M app/views/notes/index.rss.builder (6)
    M app/views/notes/show.gpx.builder (2)
    M app/views/notes/show.rss.builder (6)
    M app/views/trace/georss.rss.builder (6)
    M app/views/user/api_read.builder (14)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20160907/2f2af711/attachment.html>

More information about the rails-dev mailing list