[openstreetmap/openstreetmap-website] Refactor diary tests (#1285)

Tom Hughes notifications at github.com
Wed Sep 14 18:08:14 UTC 2016


>    end
>  
>    def test_list_user
> +    diary_entry = create(:diary_entry)
> +    geo_entry = create(:diary_entry, :latitude => 51.50763, :longitude => -0.10781)

So the problem here is that by only creating those two entries we are no longer testing that the right posts get selected because there are no non-matching posts in the database. Much the same applies to the other list tests.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1285/files/d26f4074faf4fcc5ebb1b6a0928edf3aae9c2aee#r78803387
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20160914/9e7fa86b/attachment.html>


More information about the rails-dev mailing list