[openstreetmap/openstreetmap-website] Enable the app to be built using Docker (#1290)

Paul Sturgess notifications at github.com
Sat Sep 17 11:50:25 UTC 2016


OK so I think I've addressed the comments.

- Changed the installed packages to follow the minimum requirements specified in `INSTALL.md`
- Use `bundle exec rails s -p 3000 -b '0.0.0.0'`
- Moved `docker_postgres.sh` into `/db` to reduce the noise in the root directory (I can't move all the files due to the way docker will not `../` backwards to access files)
- Added more info to the `DOCKER.md`
- Tweaked the `INSTALL.md` to state installing directly is best supported approach.

The app boots and it appears to load ok, but I'm not familiar with it at all.

There are 4 specs that either error or fail locally. The output is below. Does anyone know what might be causing those? 

<details>
<summary>Spec failure output</summary>
```
1) Error:
DiaryEntryTest#test_diary_entry_visible_comments:
ActiveRecord::InvalidForeignKey: PG::ForeignKeyViolation: ERROR:  insert or update on table "diary_entries" violates foreign key constraint "diary_entries_language_code_fkey"
DETAIL:  Key (language_code)=(en) is not present in table "languages".
: INSERT INTO "diary_entries" ("title", "body", "user_id", "created_at", "updated_at") VALUES ($1, $2, $3, $4, $5) RETURNING "id"
    test/models/diary_entry_test.rb:37:in `test_diary_entry_visible_comments'


  2) Error:
DiaryEntryTest#test_diary_entry_comments:
ActiveRecord::InvalidForeignKey: PG::ForeignKeyViolation: ERROR:  insert or update on table "diary_entries" violates foreign key constraint "diary_entries_language_code_fkey"
DETAIL:  Key (language_code)=(en) is not present in table "languages".
: INSERT INTO "diary_entries" ("title", "body", "user_id", "created_at", "updated_at") VALUES ($1, $2, $3, $4, $5) RETURNING "id"
    test/models/diary_entry_test.rb:30:in `test_diary_entry_comments'


  3) Error:
DiaryEntryTest#test_diary_entry_visible:
ActiveRecord::InvalidForeignKey: PG::ForeignKeyViolation: ERROR:  insert or update on table "diary_entries" violates foreign key constraint "diary_entries_language_code_fkey"
DETAIL:  Key (language_code)=(en) is not present in table "languages".
: INSERT INTO "diary_entries" ("title", "body", "user_id", "created_at", "updated_at") VALUES ($1, $2, $3, $4, $5) RETURNING "id"
    test/models/diary_entry_test.rb:21:in `test_diary_entry_visible'


  4) Failure:
TraceTest#test_xml_file [/app/test/models/trace_test.rb:145]:
--- expected
+++ actual
@@ -1 +1,2 @@
-"848caa72f2f456d1bd6a0fdf228aa1b9"
+# encoding: US-ASCII
+"d41d8cd98f00b204e9800998ecf8427e"
```
</details>

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1290#issuecomment-247765213
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20160917/69c6b9af/attachment-0001.html>


More information about the rails-dev mailing list