[openstreetmap/openstreetmap-website] Add MAPS.ME authentication (#1433)

Ilya Zverev notifications at github.com
Thu Feb 9 16:27:56 UTC 2017


> So on the basis of that it seems to me that this is missing tests for the token based flow?

Possibly. I'll see how to do them then.

> As far as "verified" emails go I understand what you're saying but we really want to be sure we can at least send a working welcome email, which means knowing that the email is working right now.

So why do we have verified email providers then? You can register in Google with your other, non-gmail email, which I did. Google does not send anything to that email, apart from rare google docs notifications. You could have registered in Yahoo Mail 20 years ago and use the account only for authentication. Verification flag for these was introduced in 104727f889aaf31f917c8243014b161732b6e351 in 2012. Are you saying we don't trust any third-party server now and the e-mail should be validated in all cases?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1433#issuecomment-278693901
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20170209/a7a7c53b/attachment.html>


More information about the rails-dev mailing list