[openstreetmap/openstreetmap-website] Implemented right-click context menu (#1030)

Tom Hughes notifications at github.com
Sun Feb 12 12:26:48 UTC 2017


No it's just bad style to create javascript variables and functions at global scope because you have no idea when they might clash with some other bit of javascript you're pulling in.

Good design is to isolate stuff in anonymous functions to control name visibility. I'd need to look at this in detail to see the best way to do it but I'm sure it's possible.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1030#issuecomment-279215132
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20170212/bbce628e/attachment.html>


More information about the rails-dev mailing list