[openstreetmap/openstreetmap-website] Add greeting to changeset comment notification (#1469)

Hervé Saint-Amand notifications at github.com
Mon Feb 27 22:46:53 UTC 2017


In PR #1401 we added a new I18N string, `notifier.changeset_comment_notification.hi`, whose value is `"Hi %{to_user},"`. It's now been translated to 32 languages (if I'm grepping right).

The only other email that doesn't already open with a greeting is `friend_notification`.

This PR does two things:

1. start using the new string in the changeset comment notification template
2. add a a new string, `notifier.friend_notification.hi`, which is a copy of the `changeset_comment_notification.hi` (IIUC there's no way around the translatewiki pipeline, even for strings that are identical to previous ones?) Once translated this can be added to the friend_notification templates.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/1469

-- Commit Summary --

  * Included greeting string in changeset_comment_notification email
  * Added new I18N string: notifier.friend_notification.hi

-- File Changes --

    M app/models/notifier.rb (1)
    M app/views/notifier/changeset_comment_notification.html.erb (3)
    M app/views/notifier/changeset_comment_notification.text.erb (2)
    M config/locales/en.yml (1)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/1469.patch
https://github.com/openstreetmap/openstreetmap-website/pull/1469.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1469
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20170227/5ec9a276/attachment.html>


More information about the rails-dev mailing list