[openstreetmap/openstreetmap-website] Missing feature tests (#1570)

Andy Allan notifications at github.com
Wed Jul 5 13:44:57 UTC 2017

> It's not true that controller tests don't render views by the way - they absolutely do.

My mistake. Minitest (and rails, by default) have different setup and naming to what I'm used to with RSpec.

The tests were added in fe1e28b4f45f6aa4bb53dc5163c187c5206b66a7 . I will make sure to add "[system](http://guides.rubyonrails.org/testing.html#system-testing)" tests instead of controller tests in future pull requests (e.g. `visit login_url`, `fill_in :email, :with => user.email` etc). But I won't keep this issue open here given there's no further specific actions required.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20170705/f09f8f64/attachment.html>

More information about the rails-dev mailing list