[openstreetmap/openstreetmap-website] Remove fixtures (#1556)

Andy Allan notifications at github.com
Thu Jun 1 13:26:04 UTC 2017

gravitystorm commented on this pull request.

> @@ -2036,37 +2046,46 @@ def test_list_max_id
   # This should display the last 20 changesets closed
   def test_feed
+    changeset = create(:changeset, :num_changes => 1)
+    _empty_changeset = create(:changeset, :num_changes => 0)

I think this might be a misleading comment - the controller code doesn't appear to check for open vs closed. In fact the [comment in the code](https://github.com/openstreetmap/openstreetmap-website/blob/4cd2d22788cbc8acf411c9f9436eee85a4590c5f/app/controllers/changeset_controller.rb#L251) suggests that it should only be /open/ changesets, which I think is a second misleading comment!

The changeset in the test here is open anyway, but I can add a closed one to test the behaviour.

Do you think I should update both comments to simply reference "changesets" rather than open or closed?

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20170601/a115828d/attachment.html>

More information about the rails-dev mailing list