[openstreetmap/openstreetmap-website] Remove fixtures (#1556)

Tom Hughes notifications at github.com
Thu Jun 1 10:45:32 UTC 2017


tomhughes requested changes on this pull request.



> @@ -2036,37 +2046,46 @@ def test_list_max_id
   ##
   # This should display the last 20 changesets closed
   def test_feed
+    changeset = create(:changeset, :num_changes => 1)
+    _empty_changeset = create(:changeset, :num_changes => 0)
+

I think we should create a changeset that is still open here, to make sure it doesn't get included in the feed result - that was (admittedly very non-obviously) being tested before,

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1556#pullrequestreview-41472897
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20170601/519d9ae4/attachment.html>


More information about the rails-dev mailing list