[openstreetmap/openstreetmap-website] User factory for user_controller tests (#1488)

[Andy Allan]

This replaces the fixtures in the user_controller tests with factories.

Note that two of the tests still have explicit dependencies on the fixtures, where they are counting the total number of users in the database. But we can't remove the fixtures yet since there's still more refactoring to do.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/1488

-- Commit Summary --

  * Build pending users via factory
  * Use users factory for user_controller tests.

-- File Changes --

    M test/controllers/user_controller_test.rb (350)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/1488.patch
https://github.com/openstreetmap/openstreetmap-website/pull/1488.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1488
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20170315/a90f3bd3/attachment.html>