[openstreetmap/openstreetmap-website] More node factories (#1506)

[Andy Allan]

This PR contains more conversions to use the node factories. I've also added the `with_history` option to the node factory to create the correct number of old_nodes, for when a realistic history is required.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/1506

-- Commit Summary --

  * Add a with_history trait for node factories, to automatically create corresponding old_nodes
  * Use factories for nodes in browse_helper tests.
  * For deleted nodes created via factories, make sure the most recent old_node is also deleted
  * Use node factories for browse_controller tests.

-- File Changes --

    M test/controllers/browse_controller_test.rb (16)
    M test/factories/node.rb (19)
    M test/helpers/browse_helper_test.rb (137)
    M test/models/redaction_test.rb (10)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/1506.patch
https://github.com/openstreetmap/openstreetmap-website/pull/1506.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1506
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20170330/54a110e8/attachment.html>