[openstreetmap/openstreetmap-website] Add MAPS.ME authentication (#1433)

Gregory notifications at github.com
Sat May 6 12:05:36 UTC 2017


I don't normally look at these pull requests, but I was invited here by [email](https://docs.google.com/document/d/1QUN3NaO6n1WU4mBa8pq2lyh5ga79UpJGSxAlzJGf2mQ/edit) (sent to an unknown number of people).

* I see nothing wrong with this pull request generally.
* It would be great to see a policy on what providers are given as OSM login options.
** Maybe differing policies for if they're OSM/map-related orgs(e.g. Maps.me) or not (e.g. Google, Wikimedia)
* I do not think a vote is acceptable for a technical pull request, especially one with such leading language on the options. I.e. the option "Not sure. I think OSM community can survive without millions of POI mappers." should be "Not sure."

I hope this discussion gets suitable attention so that it is easier to decide this pull request and future ones.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1433#issuecomment-299635511
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20170506/9ed1f62c/attachment.html>


More information about the rails-dev mailing list