[openstreetmap/openstreetmap-website] More factory refactoring (#1538)

[Andy Allan]

This PR focusses on the api_controller tests, along with the old_node/way/relation controller tests.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/1538

-- Commit Summary --

  * Refactor remaining api_controller tests to use factories.
  * Ensure the old nodes are created with the same changeset
  * Convert remaining old_node_controller tests to use factories.
  * Update old_ways_controller tests to use factories.
  * Refactor old_relation_controller tests to use factories.

-- File Changes --

    M test/controllers/api_controller_test.rb (47)
    M test/controllers/old_node_controller_test.rb (166)
    M test/controllers/old_relation_controller_test.rb (132)
    M test/controllers/old_way_controller_test.rb (154)
    M test/factories/node.rb (2)
    M test/factories/relation.rb (15)
    M test/factories/way.rb (15)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/1538.patch
https://github.com/openstreetmap/openstreetmap-website/pull/1538.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1538
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20170510/1f02ac45/attachment.html>