[openstreetmap/openstreetmap-website] Final Factory refactoring (#1555)

[Andy Allan]

This is the final refactoring of the test suite to use factories. Finally!

I will make a separate PR for removing the fixtures, since I expect to find some tests that have hidden dependencies on the fixtures being loaded.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/1555

-- Commit Summary --

  * Refactor remaining way model tests to use factories.
  * Refactor various controller tests to use factories.
  * Refactor some controller tests to use factories.
  * Refactor remaining relation model tests to use factories.
  * Refactor some controller tests to use factories.
  * refactor remaining amf controller tests to use factories.
  * Update rubocop class length limit.

-- File Changes --

    M .rubocop_todo.yml (2)
    M test/controllers/amf_controller_test.rb (38)
    M test/controllers/browse_controller_test.rb (24)
    M test/controllers/changeset_controller_test.rb (13)
    M test/controllers/relation_controller_test.rb (75)
    M test/controllers/search_controller_test.rb (20)
    M test/controllers/site_controller_test.rb (4)
    M test/models/relation_test.rb (50)
    M test/models/way_test.rb (57)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/1555.patch
https://github.com/openstreetmap/openstreetmap-website/pull/1555.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1555
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20170531/f9483df6/attachment.html>