[openstreetmap/openstreetmap-website] Add framework for system tests (#1664)

Andy Allan notifications at github.com
Wed Nov 15 11:28:43 UTC 2017


I'm definitely pro system tests in general, but I found two issues with this PR to discuss:

* The screenshots appear as base64 output in my terminal (Ubuntu 16.04). From [a related pull request](https://github.com/rails/rails/pull/28185), it seems some rails devs are aware that the inline images aren't supported by certain terminals. Should we disable them here, or report upstream?
* The system tests aren't run by default. The [rails docs confirms this](http://guides.rubyonrails.org/testing.html#system-testing), but doesn't offer any way to change the behaviour. I think it's important that they are run alongside the model, controller and integration tests. What do you think?

Beyond these, all looks good to me.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1664#issuecomment-344565273
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20171115/107f6a3c/attachment.html>


More information about the rails-dev mailing list