[openstreetmap/openstreetmap-website] Fix destinations and roundabouts locale (#1805)

Jamie Guthrie notifications at github.com
Sun Apr 1 14:48:23 UTC 2018

Done a few changes here.

I refactored the with_destination locale so its just a string that one can append onto the end of an instruction. Hopefully it will still work with different grammar structures in different languages!

I also fixed some ambiguous roundabout instructions..
i.e. https://www.openstreetmap.org/directions?engine=osrm_car&route=53.7338%2C-1.5258%3B53.6832%2C-1.4999#map=13/53.7086/-1.5171

Instructions 7-16 are a bit weird - so I've fixed it to specify `"Exit straight/slight right/right from roundabout"` when exiting roundabouts
You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * Refactored destinations locale into separate instruction
  * Refactored locale templates and fixed roundabout exiting templates

-- File Changes --

    M app/assets/javascripts/index/directions/osrm.js (29)
    M config/locales/en.yml (80)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20180401/8e8c76da/attachment.html>

More information about the rails-dev mailing list