[openstreetmap/openstreetmap-website] Add marker at trace start coordinate (#1731)

Matt Amos notifications at github.com
Sun Feb 4 12:20:31 UTC 2018


It looks like [`link_to_if`](https://apidock.com/rails/ActionView/Helpers/UrlHelper/link_to_if) isn't going to evaluate the link when `trace.inserted?` is false. I thnk that means that the trace will have non-nil lat/lon whenever `trace.inserted?` is true, so it shouldn't cause a problem?

There are some [other places in the code](https://github.com/openstreetmap/openstreetmap-website/blob/609cedc4998805d38d1607e68c67e491ce589114/app/models/trace.rb#L182-L183) where we're assuming `inserted?` implies lat/lon are present.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1731#issuecomment-362902663
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20180204/5fb417f1/attachment.html>


More information about the rails-dev mailing list