[openstreetmap/openstreetmap-website] Refactor trace creation pages (#1892)

Andy Allan notifications at github.com
Wed Jun 6 02:46:54 UTC 2018


This PR splits the trace creation into new and create methods, with standard resourceful routing. It provides a redirect for any external get requests to the old url. To prevent anyone from getting an error during deployment, the old POST target is honoured for now, but can be removed shortly after deployment since it's not an external url.

@Nikerabbit this PR contains some translation key changes:

* `traces.create.upload_trace`, `traces.create.trace_uploaded` and `traces.create.traces_waiting.*` remain as they were.
* All other `traces.create.*` become `traces.new.*`
* `traces.new.upload_trace` is a duplicate of the existing `traces.create.upload_trace`
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/1892

-- Commit Summary --

  * Refactor trace creation pages

-- File Changes --

    M .rubocop_todo.yml (2)
    M app/controllers/traces_controller.rb (65)
    M app/views/traces/list.html.erb (4)
    R app/views/traces/new.html.erb (0)
    M config/locales/en.yml (12)
    M config/routes.rb (4)
    M test/controllers/traces_controller_test.rb (26)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/1892.patch
https://github.com/openstreetmap/openstreetmap-website/pull/1892.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1892
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20180605/440e06e9/attachment.html>


More information about the rails-dev mailing list