[openstreetmap/openstreetmap-website] Added color preview box in tag browser sidebar (#1779)

Ilya Zverev notifications at github.com
Tue Mar 6 09:46:28 UTC 2018


Zverik commented on this pull request.



> @@ -188,4 +190,16 @@ def telephone_link(_key, value)
 
     "tel:#{value_no_whitespace}"
   end
+
+  def colour_preview(key, value)
+    return nil unless (key =~ /^(|building:|ref:|roof:)colour$/ || key =~ /^(int_)?ref:colour(_(bg|tx))?$/) && !value.nil?

Maybe make it more generic? [Taginfo shows](https://taginfo.openstreetmap.org/search?q=%3Acolour) many other colour tags, including three for seamarks and longer variants like `building:roof:colour`.

And `int_ref:colour` options are in hundreds, why make a clause specifically for these?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1779#pullrequestreview-101475976
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20180306/127989a8/attachment.html>


More information about the rails-dev mailing list