[openstreetmap/openstreetmap-website] Added color preview box in tag browser sidebar (#1779)
notifications at github.com
Wed Mar 7 04:17:12 UTC 2018
gravitystorm commented on this pull request.
> @@ -188,4 +190,16 @@ def telephone_link(_key, value)
+ def colour_preview(key, value)
+ return nil unless (key =~ /^(|building:|ref:|roof:)colour$/ || key =~ /^(int_)?ref:colour(_(bg|tx))?$/) && !value.nil?
I'm very much opposed to anything that shows tagging mistakes as if they are correctly tagged. It's part of the guidelines established for the openstreetmap-carto project, and I'd like to apply similar guidelines to the browse pages:
"It's an important feedback mechanism for mappers to validate their edits and helps to prevent unfavorable fragmentation of tag use."
So no "color" tags and nothing that would show e.g. "buidling:colour" (note misspelling).
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the rails-dev