[openstreetmap/openstreetmap-website] Wrap the permission label with a <label> tag (#1880)

Andy Allan notifications at github.com
Fri May 25 01:11:33 UTC 2018


Thanks @EdwardBetts ! This fixes a pet peeve of mine. There's lots more situations like this throughout the codebase, a simple search of `app/views` shows lots of label tags that aren't associated with any form fields. Even the ones that have "for" attributes are often wrong - e.g. app/views/user/new.html.erb where none of the label "for" attributes match the id of the form field. If you get the chance, fixing some of these, and moving them to rails tag helpers, would be appreciated too!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1880#issuecomment-391911628
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20180524/eb2e721a/attachment-0001.html>


More information about the rails-dev mailing list